Skip to content

Conversation

@alex
Copy link
Contributor

@alex alex commented Aug 1, 2017

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS;

@nicoddemus
Copy link
Member

Nice, thank you! 👍

@nicoddemus nicoddemus merged commit 02da156 into pytest-dev:master Aug 1, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.815% when pulling 8406123 on alex:patch-1 into 0a15edd on pytest-dev:master.

@alex alex deleted the patch-1 branch August 1, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants