Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fixtures to use capsys and capfd #2801

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Allow fixtures to use capsys and capfd #2801

merged 3 commits into from
Oct 9, 2017

Conversation

nicoddemus
Copy link
Member

Fix #2709

Also refactor some names for better understanding and consistency, and although they are all internal I'm targeting features. Those renames are in a separate commit and we can drop it if we wouldn't like to touch the names.

@coveralls
Copy link

Coverage Status

Coverage increased (+30.1%) to 92.513% when pulling 22f338d on nicoddemus:capture-fixture into de0d19c on pytest-dev:features.

@nicoddemus nicoddemus changed the title Allow to use capsys and capfd in other fixtures Allow fixtures to use capsys and capfd Sep 27, 2017
@nicoddemus
Copy link
Member Author

My last commit also fixes #1993, including using the full script provided by @jcfr in this comment (thanks again!).

@coveralls
Copy link

Coverage Status

Coverage increased (+30.08%) to 92.487% when pulling f9589f7 on nicoddemus:capture-fixture into de0d19c on pytest-dev:features.

@jcfr
Copy link

jcfr commented Sep 29, 2017

Well done @nicoddemus and thanks for the shout out. 🎆

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this whole thing is layered in trouble - this one is a good next step

@RonnyPfannschmidt RonnyPfannschmidt merged commit 9b0ce53 into pytest-dev:features Oct 9, 2017
@nicoddemus nicoddemus deleted the capture-fixture branch October 9, 2017 13:27
@epassaro epassaro mentioned this pull request Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicoddemus @coveralls @jcfr @RonnyPfannschmidt