-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new environment marker usages #3098
Add support for new environment marker usages #3098
Conversation
b674a7b
to
9923b51
Compare
LGTM, but I will defer to @RonnyPfannschmidt because he's more knowledgeable about |
it looks lgtm, but based on the surrounding changelog the version used is incorrect based on the change log it was introduced in |
9923b51
to
432dbcf
Compare
Changed the version to 36.2.2, and added a link to the change log. I also fixed the other link to change log since it’s broken. |
432dbcf
to
b256cd2
Compare
lovely, i'll wait for the ci to pass then i'll merge good job 👍 |
merged, the failures are unrelated thanks gain 👍 |
Ref pypa/pipenv#1229.
Setuptools added a new syntax in 36.2.1 for conditional requirements. This is recommended in the documentation, and works better with dependency resolution tools that do not actually install the package.
I’m having trouble deciding whether this should be a bugfix or feature. Any suggestions?
$issue_id.$type
for example (588.bugfix)removal
,feature
,bugfix
,vendor
,doc
ortrivial
bugfix
,vendor
,doc
ortrivial
fixes, targetmaster
; for removals or features targetfeatures
;Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS
, in alphabetical order;