#2953 show a simple and easy error when keyword expressions trigger a syntax error #3121
Conversation
There was a problem hiding this comment.
Thanks! You might want to use the keyword module instead, though 😉
…rte/pytest into 2953-keyword-expressions-error
fixed =) |
_pytest/mark.py
Outdated
| return eval(keywordexpr, {}, mapping) | ||
| for kwd in keywordexpr.split(): | ||
| if keyword.iskeyword(kwd) and kwd not in python_keywords_allowed_list: | ||
| raise AttributeError("Python keyword '{}' not accepted in expressions passed to '-k'".format(kwd)) |
There was a problem hiding this comment.
I think raising UsageError might be more appropriate and provide a better user experience because it won't show up as an internal error.
…rte/pytest into 2953-keyword-expressions-error
|
@feuillemorte I tested this locally and is looking good, thanks! I just pushed a change that makes the error message appear in red to make it more visible. 😉 After this passes I think we can merge it. 👍 |
|
Let's wait for @The-Compiler to take a second look before we merge it. 👍 |
|
LGTM! Travis is currently recovering from an outage, so that'll probably take a bit. |
|
@The-Compiler thanks for the info. Should we restart the Travis job? Not sure from the outage report if that's something we should attempt or not. |
|
Hmm, dunno. I'd say let's just wait some more hours since the job apparently wasn't cancelled. |
|
@The-Compiler the problem was solved. could you restart it, please? |
|
I don't think it'll help (as the build wasn't cancelled), but I did. |
|
Looking good now - thanks! |
If we use expressions in -k option we get an error if this expression wrong of has python keywords:
AttributeError: Python keyword 'import' not accepted in expressions passed to '-k'AttributeError: Wrong expression passed to '-k': foo or