Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ordering of tests to minimize fixture creating #3183

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Fix ordering of tests to minimize fixture creating #3183

merged 2 commits into from
Feb 7, 2018

Conversation

cheezman34
Copy link

#3108 introduced a regression in test ordering that resulted in excess fixture creation. This should fix that and order tests as they were before PR 3108.

@cheezman34 cheezman34 mentioned this pull request Feb 1, 2018
Open
@coveralls
Copy link

coveralls commented Feb 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 92.632% when pulling 3425edd on cheezman34:master into 89a55d8 on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cheezman34!

@nicoddemus nicoddemus merged commit f721829 into pytest-dev:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheezman34 @coveralls @nicoddemus