Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't traceback on unkown sections. #3188

Merged
merged 2 commits into from
Feb 17, 2018

Conversation

s0undt3ch
Copy link
Contributor

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;

@coveralls
Copy link

coveralls commented Feb 5, 2018

Coverage Status

Coverage remained the same at 92.628% when pulling 42c1f85 on s0undt3ch:issues/3184 into 570edb4 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @s0undt3ch!

@s0undt3ch
Copy link
Contributor Author

Anytime!

@nicoddemus nicoddemus merged commit 00d3001 into pytest-dev:master Feb 17, 2018
@s0undt3ch
Copy link
Contributor Author

So, when is this getting release on the wild?

@nicoddemus
Copy link
Member

This week we should release 3.4.1. 😁

@s0undt3ch
Copy link
Contributor Author

Awesome! It caused some minor grief with at least one of my coworkers :)

@s0undt3ch s0undt3ch deleted the issues/3184 branch August 28, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants