Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix approx default tolerances for Decimal #3248

Merged
merged 2 commits into from
Feb 22, 2018
Merged

Fix approx default tolerances for Decimal #3248

merged 2 commits into from
Feb 22, 2018

Conversation

durocher
Copy link
Contributor

@durocher durocher commented Feb 21, 2018 •
edited by nicoddemus
Loading

Fixes #3247
Added python_api.ApproxDecimal to handle with Decimal numbers.

@coveralls
Copy link

coveralls commented Feb 21, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 92.558% when pulling 147b43f on durocher:master into dae74b6 on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first contribution, thanks @durocher!

@RonnyPfannschmidt RonnyPfannschmidt merged commit 264e455 into pytest-dev:master Feb 22, 2018
@RonnyPfannschmidt
Copy link
Member

well done, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durocher @coveralls @RonnyPfannschmidt @nicoddemus