Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DontReadFromInput to produce iterator without error. #3315

Merged
merged 5 commits into from
Mar 16, 2018

Conversation

jaraco
Copy link
Contributor

@jaraco jaraco commented Mar 16, 2018

Fixes #3314.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaraco, the fix LGTM!

@coveralls
Copy link

coveralls commented Mar 16, 2018

Coverage Status

Coverage increased (+0.002%) to 92.511% when pulling 17468fc on issue/3314 into fbcf1a9 on master.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after having initial doubts about whether to use StopIteration for __iter__

however the intend is to fail in general

@nicoddemus nicoddemus merged commit 93847bf into master Mar 16, 2018
@nicoddemus nicoddemus deleted the issue/3314 branch March 16, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants