-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #3498 - correctly consider marks on unittest classes #3500
fix #3498 - correctly consider marks on unittest classes #3500
Conversation
@pytest.mark.parametrize("base", [ | ||
'six.moves.builtins.object', | ||
'unittest.TestCase', | ||
'unittest2.TestCase', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never install unittest2
, should we add it to our testing dependencies in tox.ini
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atm i dont think thats necessary
I pulled down the changes and verified they work correctly for my use cases. Thanks for such a quick response! |
Thanks @RonnyPfannschmidt! We should have a |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.master
branch for bug fixes, documentation updates and trivial changes.features
branch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS
in alphabetical order;