Fix OS X specific code that uses capturemanager. #3891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @jirikuncar! |
nicoddemus
approved these changes
Aug 27, 2018
|
@vst @jirikuncar can you guys take this for a spin to ensure it fixes the issue? |
pytest-dev#3888 (comment) closes pytest-dev#3888 Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
|
I can run my tests on macOS High Sierra with the patch where 3.7.3 is failing. |
|
Yes. v3.7.3 is now working well as expected with this fix. @jirikuncar Thanks for the PR, and @nicoddemus, thanks for the swift action. |
|
Superseded by #3893. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3888 (comment)
closes #3888
Co-authored-by: Bruno Oliveira nicoddemus@gmail.com
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Add yourself totrivial changeAUTHORSin alphabetical order;