-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce deprecations page #3997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3997 +/- ##
=========================================
- Coverage 94.34% 94.1% -0.25%
=========================================
Files 108 108
Lines 23703 23698 -5
Branches 2353 2350 -3
=========================================
- Hits 22363 22300 -63
- Misses 1021 1075 +54
- Partials 319 323 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like what i see so far, having a detailed documentation is pretty helpfull
Ready for review! 👍 |
cc @okken |
87a8554
to
c284154
Compare
Thanks Bruno. I think it’s a good idea. |
Got the page going, wanted to see what others think.
Documenting the deprecations in the CHANGELOG often is done too briefly, while I believe we should write down the rationale and provide examples on how to update the code. I think when users understand the reasoning behind deprecations they are much more understanding.
Also examples on how to update the code currently are often provided in the docstrings of the features we plan to remove, which will disappear when we effectively remove said feature.
The idea is to keep this page around "forever" as a reference for users which encounter ancient codebases and want to revive them.
fix #3996