Skip to content

Change test_warningschecker_twice to a unittest #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

nicoddemus
Copy link
Member

Follow up to #4620 (comment)

@nicoddemus nicoddemus requested a review from Sup3rGeo January 9, 2019 21:00
@nicoddemus nicoddemus mentioned this pull request Jan 9, 2019
3 tasks
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #4622 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4622      +/-   ##
==========================================
+ Coverage   95.75%   95.75%   +<.01%     
==========================================
  Files         111      111              
  Lines       24683    24686       +3     
  Branches     2446     2446              
==========================================
+ Hits        23634    23639       +5     
  Misses        739      739              
+ Partials      310      308       -2
Flag Coverage Δ
#docs 29.56% <0%> (-0.03%) ⬇️
#doctesting 29.56% <0%> (-0.03%) ⬇️
#linting 29.56% <0%> (-0.03%) ⬇️
#linux 95.57% <100%> (-0.01%) ⬇️
#nobyte 92.37% <100%> (ø) ⬆️
#numpy 93.18% <100%> (-0.01%) ⬇️
#pexpect 42.11% <0%> (-0.01%) ⬇️
#py27 93.78% <100%> (ø) ⬆️
#py34 91.86% <100%> (+0.06%) ⬆️
#py35 91.89% <100%> (+0.07%) ⬆️
#py36 91.9% <100%> (+0.05%) ⬆️
#py37 93.93% <100%> (ø) ⬆️
#trial 93.18% <100%> (-0.01%) ⬇️
#windows 93.94% <100%> (ø) ⬆️
#xdist 93.79% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_warnings.py 98.86% <100%> (+0.01%) ⬆️
src/_pytest/cacheprovider.py 96.69% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b6425...e4a21b1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #4622 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4622      +/-   ##
==========================================
+ Coverage   95.75%   95.75%   +<.01%     
==========================================
  Files         111      111              
  Lines       24683    24686       +3     
  Branches     2446     2446              
==========================================
+ Hits        23634    23639       +5     
  Misses        739      739              
+ Partials      310      308       -2
Flag Coverage Δ
#docs 29.56% <0%> (-0.03%) ⬇️
#doctesting 29.56% <0%> (-0.03%) ⬇️
#linting 29.56% <0%> (-0.03%) ⬇️
#linux 95.57% <100%> (-0.01%) ⬇️
#nobyte 92.37% <100%> (ø) ⬆️
#numpy 93.18% <100%> (-0.01%) ⬇️
#pexpect 42.11% <0%> (-0.01%) ⬇️
#py27 93.78% <100%> (ø) ⬆️
#py34 91.86% <100%> (+0.06%) ⬆️
#py35 91.89% <100%> (+0.07%) ⬆️
#py36 91.9% <100%> (+0.05%) ⬆️
#py37 93.93% <100%> (ø) ⬆️
#trial 93.18% <100%> (-0.01%) ⬇️
#windows 93.94% <100%> (ø) ⬆️
#xdist 93.79% <100%> (ø) ⬆️
Impacted Files Coverage Δ
testing/test_warnings.py 98.86% <100%> (+0.01%) ⬆️
src/_pytest/cacheprovider.py 96.69% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b6425...e4a21b1. Read the comment docs.

@nicoddemus nicoddemus merged commit 2359663 into pytest-dev:master Jan 10, 2019
@nicoddemus nicoddemus deleted the warningschecker-unittest branch January 10, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants