Add test for mtime issue in #4903 #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bmwiedemann
reviewed
Mar 14, 2019
testing/test_assertrewrite.py
Outdated
| ) | ||
| # use unsigned long timestamp which overflows signed long, | ||
| # which was the cause of the bug | ||
| timestamp = 2 ** 32 - 1 |
There was a problem hiding this comment.
You could add another test with 2**32 + 1 - that is where the added 0xFFFFFFFF of my patch comes into play.
There was a problem hiding this comment.
Good suggestion, done. 👍
nicoddemus
force-pushed
the
mtime-test-for-4903
branch
from
2748ecc to
bd70f5c
Compare
bmwiedemann
approved these changes
Mar 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
==========================================
+ Coverage 95.69% 95.71% +0.02%
==========================================
Files 113 113
Lines 25170 25176 +6
Branches 2498 2498
==========================================
+ Hits 24086 24097 +11
+ Misses 766 764 -2
+ Partials 318 315 -3
Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #4903 (comment).
I verified this manually against
features(which still doesn't contain the original patch) and verified that the test breaks as expected with the original exception.