Emit a warning for record_property when used with xunit2 #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
record-property-xunit2
branch
from
2a995b7
to
4430042
Compare
Codecov Report
@@ Coverage Diff @@
## features #5204 +/- ##
============================================
+ Coverage 96.12% 96.13% +<.01%
============================================
Files 115 115
Lines 26023 26037 +14
Branches 2566 2567 +1
============================================
+ Hits 25015 25030 +15
Misses 706 706
+ Partials 302 301 -1
Continue to review full report at Codecov.
|
blueyed
reviewed
May 5, 2019
"property" elements cannot be children of "testsuite" according to the schema, so it is incompatible with xunit2 Related to pytest-dev#5202
nicoddemus
force-pushed
the
record-property-xunit2
branch
from
4430042
to
8f23e19
Compare
blueyed
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propertyelements cannot be children oftestsuiteaccording to the schema, so it is incompatible with xunit2Related to #5202
cc @danilomendesdias