Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat ini keys defined in conftest.py as invalid #7384

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Don't treat ini keys defined in conftest.py as invalid #7384

merged 2 commits into from
Jun 18, 2020

Conversation

gnikonorov
Copy link
Member

@gnikonorov gnikonorov commented Jun 18, 2020 •
edited
Loading

The warning/error output of invalid plugins introduced here: #7286 ( sorry ) does not properly respect ini keys defined in conftest.py. This change fixes that, and adds a test case that catches this bug.

I didn't add a changelog entry, since the feature still isn't released: https://github.com/pytest-dev/pytest/blob/master/changelog/6856.feature.rst

Closes #7383

@gnikonorov gnikonorov self-assigned this Jun 18, 2020
@gnikonorov
Copy link
Member Author

Looks like codecov was down. @RonnyPfannschmidt @nicoddemus can we re-run this PR ( or just review and/or merge if you're ok with the below error ) I don't think this is related to my change at all

     -> Pinging Codecov
https://codecov.io/upload/v4?package=bash-20200602-f809a24&token=secret&branch=issue_7383&commit=e6ff0df234a2a4f607b8a50a8d53bc5d899ef553&build=139174374&build_url=http%3A%2F%2Fgithub.com%2Fpytest-dev%2Fpytest%2Factions%2Fruns%2F139174374&name=windows-py35&tag=&slug=pytest-dev%2Fpytest&service=github-actions&flags=GHA,Windows&pr=7384&job=
    -> Uploading
    X> Failed to upload
    -> Sleeping for 30s and trying again...
    -> Uploading to Codecov
    -> Sleeping for 30s and trying again...
    -> Sleeping for 30s and trying again...
    -> Sleeping for 30s and trying again...
    -> Sleeping for 30s and trying again...
    X> Failed to upload coverage reports
##[error]Process completed with exit code 1.

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the swift followup, its always great if those get handled before a release

@gnikonorov
Copy link
Member Author

Of course @RonnyPfannschmidt. Looks like unrelated unit tests are failing this time for pypy3

@nicoddemus nicoddemus merged commit 4cc4ebf into pytest-dev:master Jun 18, 2020
@The-Compiler The-Compiler mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees

@gnikonorov gnikonorov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest does not respect ini values defined in conftest.py as validly defined
3 participants
@gnikonorov @RonnyPfannschmidt @nicoddemus