Make --strict imply both strictness options #7529
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC for #7503. It looks like there was a consensus that this is the right thing to do, but not on whether this can still go to pytest 6 in such a late stage or should wait for pytest 7.
IMHO it's fine to have in pytest 6 since we already documented this possibility in the changelog for pytest 4.5.0 ("The existing --strict option has the same behavior currently, but can be augmented in the future for additional checks.") and discouraged it in the documentation (The use of
--strict-markers
is highly preferred.--strict
was kept for backward compatibility only and may be confusing for others as it only applies to markers and not to other options.)Let me know what you think.