findpaths: fix regression causing incorrect rootdir to be determined #7813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching from py.path.local to pathlib (70f3ad1), `local.parts(reverse=True)` was translated incorrectly, leading to the wrong rootdir being determined in some non-trivial cases where parent directories have config files as well.
bluetech
added
the
needs backport
nicoddemus
approved these changes
Sep 29, 2020
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Sep 30, 2020
findpaths: fix regression causing incorrect rootdir to be determined (cherry picked from commit b250c9d)
|
When's 6.1.1 due to be released? (which I assume will include this fix?) |
Member
|
@cjw296 "soon" according to #7814 (comment) 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7807.
When switching from py.path.local to pathlib (70f3ad1),
local.parts(reverse=True)was translated incorrectly, leading to the wrong rootdir being determined in some non-trivial cases where parent directories have config files as well.