Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytest 7.0] Make --version write to stdout rather than stderr #8247

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

nicoddemus
Copy link
Member

Fix #8246

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to keep this until pytest 7? In case someone already relies on the stderr behavior, which will break now, and there isn't really any way to provide backward compat.

Anyway, either decision is fine by me.

@nicoddemus
Copy link
Member Author

We might want to keep this until pytest 7? In case someone already relies on the stderr behavior, which will break now, and there isn't really any way to provide backward compat.

Hmm good point. I'm fine on waiting for pytest 7. @RonnyPfannschmidt ?

@RonnyPfannschmidt
Copy link
Member

i agree

@nicoddemus
Copy link
Member Author

Done, thanks!

@nicoddemus nicoddemus changed the title Make --version write to stdout rather than stderr [pytest 7.0] Make --version write to stdout rather than stderr Jan 17, 2021
Base automatically changed from master to main March 9, 2021 20:40
@nicoddemus nicoddemus added this to the 7.0 milestone Mar 19, 2021
@nicoddemus
Copy link
Member Author

Just bumped into this.

@The-Compiler what do you think about getting this into 7.0.0rc1?

@The-Compiler
Copy link
Member

Seems fine to me, given that it's been reviewed and is simple enough. Maybe rebase though, so that the CI can run against it again?

@nicoddemus nicoddemus force-pushed the version-stdout-8246 branch from 19d13c0 to 0def01d Compare June 28, 2021 18:54
@nicoddemus
Copy link
Member Author

Sure, rebased! 👍

@nicoddemus
Copy link
Member Author

oops ignore that, I got it wrong.

@The-Compiler
Copy link
Member

Looks like you rebased before pulling my lastest changes in main or something 😉

@nicoddemus nicoddemus force-pushed the version-stdout-8246 branch from 0def01d to 109312b Compare June 28, 2021 18:56
@nicoddemus
Copy link
Member Author

Done now. 😁

@nicoddemus nicoddemus enabled auto-merge June 28, 2021 18:57
@nicoddemus
Copy link
Member Author

Looks like you rebased before pulling my lastest changes in main or something

The classic "origin/main" vs "upstream/main" hehehe 😉

@nicoddemus nicoddemus merged commit 1d67553 into pytest-dev:main Jun 28, 2021
@h-vetinari
Copy link

Bit of a nit, but this shows up as having been done in the 8.0 milestone, instead of 7.0 (the version with which it now will be released). Same for #7870.

@nicoddemus nicoddemus modified the milestones: 8.0, 7.0 Jun 29, 2021
@nicoddemus
Copy link
Member Author

Thanks @h-vetinari, fixed!

@nicoddemus nicoddemus deleted the version-stdout-8246 branch June 29, 2021 12:30
@The-Compiler
Copy link
Member

Me: Huh, that seems quite exotic, why would someone rely on this behavior?

Also me: Relies on that behavior in integration tests for a coverage checking script 🤣

The-Compiler added a commit to qutebrowser/qutebrowser that referenced this pull request Jul 6, 2021
mkonig pushed a commit to mkonig/qutebrowser that referenced this pull request Dec 7, 2021
twigleingrid pushed a commit to twigleingrid/qutebrowser that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--version writes to stderr
5 participants