-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pytest 7.0] Make --version write to stdout rather than stderr #8247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to keep this until pytest 7? In case someone already relies on the stderr behavior, which will break now, and there isn't really any way to provide backward compat.
Anyway, either decision is fine by me.
Hmm good point. I'm fine on waiting for pytest 7. @RonnyPfannschmidt ? |
i agree |
65ef4df
to
19d13c0
Compare
Done, thanks! |
Just bumped into this. @The-Compiler what do you think about getting this into |
Seems fine to me, given that it's been reviewed and is simple enough. Maybe rebase though, so that the CI can run against it again? |
19d13c0
to
0def01d
Compare
Sure, rebased! 👍 |
oops ignore that, I got it wrong. |
Looks like you rebased before pulling my lastest changes in |
0def01d
to
109312b
Compare
Done now. 😁 |
The classic "origin/main" vs "upstream/main" hehehe 😉 |
Bit of a nit, but this shows up as having been done in the 8.0 milestone, instead of 7.0 (the version with which it now will be released). Same for #7870. |
Thanks @h-vetinari, fixed! |
Me: Huh, that seems quite exotic, why would someone rely on this behavior? Also me: Relies on that behavior in integration tests for a coverage checking script 🤣 |
Fix #8246