Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct log_file's inconsistent behavior #9700

Closed
wants to merge 4 commits into from
Closed

Correct log_file's inconsistent behavior #9700

wants to merge 4 commits into from

Conversation

pralkarz
Copy link

@pralkarz pralkarz commented Feb 19, 2022

Close #7336

Per @symonk's comment on that issue I took his PR #7350 as a starting point, and extended it per @bluetech's first insight in that PR. Not sure whether I should tackle the second one as well,

In summary:

  • When --log-file is passed as a cli argument, its location is relative to the invocation path.
  • When --log-file isn't passed as a cli argument and log_file option is present in the config, log file's location is relative to the config file.

@pralkarz pralkarz changed the title Correct log_file behavior that's inconsistent with documentation Correct log_file's behavior that's inconsistent with documentation Feb 19, 2022
@pralkarz pralkarz changed the title Correct log_file's behavior that's inconsistent with documentation Correct log_file's inconsitent behavior Apr 9, 2022
@pralkarz pralkarz changed the title Correct log_file's inconsitent behavior Correct log_file's inconsistent behavior Apr 9, 2022
@Zac-HD Zac-HD mentioned this pull request Apr 21, 2022
@pralkarz pralkarz deleted the iss7336-log-file-inconsistency branch April 24, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inaccurate documentation
1 participant