feat: Add counter metrics to track quote submission #466
+42
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
guibescos
reviewed
Apr 3, 2025
| ) -> Result<VersionedTransaction, RestError> { | ||
| let result = self.submit_quote_inner(input).await; | ||
| let result_metric_label = if let Err(err) = &result { | ||
| err.error_name().to_string() |
There was a problem hiding this comment.
why not use variant_name directly here?
|
@Dewyer We may close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
These changes should add extra metrics to submit quote about the kind of result that was received during the execution.
Metrics
The code below creates these metrics, under
submit_quote_result, and the result label contains the variant that was encountered.Changes in the tiltfile
I made changes to the tiltfile that should add linux compatibility to the test searchers, while still working on mac os as well.