changed c return value of update price to indicate aggregation #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
requested changes
Jul 19, 2022
guibescos
reviewed
Jul 19, 2022
guibescos
pushed a commit
that referenced
this pull request
Jul 20, 2022
…#191) * changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * made successful aggregate update greater than 15 * timeless coments * clarified c_oracle_header comment * added comment clarifying that 0 is success
majabbour
added a commit
that referenced
this pull request
Jul 21, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 21, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 21, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
guibescos
pushed a commit
that referenced
this pull request
Jul 22, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
guibescos
pushed a commit
that referenced
this pull request
Jul 22, 2022
* changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * added comment clarifying that 0 is success * a convinient way to derive traits * silenced unused bindings warnings * removed dead code * added a comment explaining the structure * changed importing style * called fmt on bindings output * added register_traits method * removed unnecessary match * fixed formatting * made it easier to add borsch to more types by not using vectors
majabbour
added a commit
that referenced
this pull request
Jul 22, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 22, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 22, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
guibescos
added a commit
that referenced
this pull request
Jul 25, 2022
* changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * added comment clarifying that 0 is success * a convinient way to derive traits * silenced unused bindings warnings * removed dead code * added a comment explaining the structure * changed importing style * called fmt on bindings output * added register_traits method * removed unnecessary match * fixed formatting * made it easier to add borsch to more types by not using vectors * changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * Switch from vector to slice to allow adding traits to multiple structs * Logging 2 * Prelog and postlog instructions * Fix CI * Remove accidental commits * Remove line * Clippy * Format and reorder * Add comment about accessing account 1 * Remove old offset file * Remove duplicate comment Co-authored-by: majabbour <59592028+majabbour@users.noreply.github.com> Co-authored-by: Mark Jabbour <markmarjabbour@gmail.com> Co-authored-by: Guillermo Bescos <guibescos>
guibescos
added a commit
that referenced
this pull request
Jul 25, 2022
* changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * added comment clarifying that 0 is success * a convinient way to derive traits * silenced unused bindings warnings * removed dead code * added a comment explaining the structure * changed importing style * called fmt on bindings output * added register_traits method * removed unnecessary match * fixed formatting * made it easier to add borsch to more types by not using vectors * changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * Switch from vector to slice to allow adding traits to multiple structs * Logging 2 * Prelog and postlog instructions * Fix CI * Remove accidental commits * Remove line * Clippy * Format and reorder * Add comment about accessing account 1 * Remove old offset file * Remove duplicate comment * More info * Don't commit bindings Co-authored-by: majabbour <59592028+majabbour@users.noreply.github.com> Co-authored-by: Mark Jabbour <markmarjabbour@gmail.com> Co-authored-by: Guillermo Bescos <guibescos>
majabbour
added a commit
that referenced
this pull request
Jul 25, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 26, 2022
* changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages
majabbour
added a commit
that referenced
this pull request
Jul 26, 2022
* changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * a convinient way to derive traits * changed importing style * added register_traits method * fixed formatting * add a new insctruction and interecepted update price calls * fixed formatting * more helpful error message for incorrect c account size * fixed merging errors * addressed some warning * updated comment * merging formatting issues * memory borrowing issues after rebasing * updated import * more import style changes * removed panics * bug introduced by merge * moved dispatching to processor * better formatting * cleaner error handling * error handling wrapper for c_entrypoint * removed unwrap * more comments * removed unused imports + changed import style
guibescos
added a commit
that referenced
this pull request
Jul 28, 2022
* Make c robust to price account size (#201) * make pythd robust * made the oracle accept new size * left space for extra publishers * Make c robust to price account size (#207) * make pythd robust * made the oracle accept new size * left space for extra publishers * Intercepting price updates (#204) * changed c return value of update price to indicate aggregation (#190) * changed c return value of update price to indicate aggregation * forgot to add bindings * removed the need for casting * fixed update_no_fail * removed unnecessary docker packages * timeless coments * a convinient way to derive traits * changed importing style * added register_traits method * fixed formatting * add a new insctruction and interecepted update price calls * fixed formatting * more helpful error message for incorrect c account size * fixed merging errors * addressed some warning * updated comment * merging formatting issues * memory borrowing issues after rebasing * updated import * more import style changes * removed panics * bug introduced by merge * moved dispatching to processor * better formatting * cleaner error handling * error handling wrapper for c_entrypoint * removed unwrap * more comments * removed unused imports + changed import style Co-authored-by: majabbour <59592028+majabbour@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used so that rust code knows whether aggregation happened