-
Notifications
You must be signed in to change notification settings - Fork 260
refactor(target_chains/ethereum): remove batch update support #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
… from updatePriceFeeds
… from parsePriceFeedUpdates and getUpdateFee
…VerificationExperiments tests
0616d9d
to
047952f
Compare
target_chains/ethereum/contracts/forge-test/VerificationExperiments.t.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice. I left some inline comments to see whether we can remove even more code! I'll approve after getting your opinions about them.
b7ea030
to
88971cd
Compare
88971cd
to
46493d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Feel free to merge it when you've removed some of the duplicate tests.
updatePriceFeeds
,parsePriceFeedUpdates
,getUpdateFee
contract functions.Batch renames are made in separate commits for easier review.
PythUpgradable
contract size reduced from 22.061 kB to 20.568 kB, according toforge build --sizes
.Gas report
No significant changes, according to
forge test --gas-report --match-contract GasBenchmark
.Reports
Old:
New: