fix(pulse): ensure subscription balance is greater than minimum balance after adding funds #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…r adding funds Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tejasbadadare
changed the title
tejasbadadare
changed the base branch from
main
to
devin/1747072255-add-max-deposit-limit-for-permanent-subscriptions
3 tasks
|
Closing due to inactivity for more than 7 days. |
ali-behjati
reviewed
May 27, 2025
Comment on lines
583
to
612
| // Now create a new subscription but don't fund it fully | ||
| SchedulerState.SubscriptionParams | ||
| memory newParams = createDefaultSubscriptionParams( | ||
| 2, | ||
| address(reader) | ||
| ); | ||
|
|
||
| // Calculate minimum balance for this new subscription | ||
| uint256 newMinimumBalance = scheduler.getMinimumBalance( | ||
| uint8(newParams.priceIds.length) | ||
| ); | ||
|
|
||
| // Try to create with insufficient funds | ||
| uint256 insufficientFunds = newMinimumBalance - 1 wei; | ||
| vm.expectRevert(abi.encodeWithSelector(InsufficientBalance.selector)); | ||
| scheduler.createSubscription{value: insufficientFunds}(newParams); | ||
|
|
||
| // Create with sufficient funds | ||
| uint256 newSubscriptionId = scheduler.createSubscription{ | ||
| value: newMinimumBalance | ||
| }(newParams); | ||
|
|
||
| // Verify subscription was created with minimum balance | ||
| (, SchedulerState.SubscriptionStatus memory newStatus) = scheduler | ||
| .getSubscription(newSubscriptionId); | ||
| assertEq( | ||
| newStatus.balanceInWei, | ||
| newMinimumBalance, | ||
| "New subscription balance should equal minimum balance" | ||
| ); |
There was a problem hiding this comment.
this is not testing balance check in addFunds. here you need to send some updates to drain the balance and then try to add funds
| ); | ||
| } | ||
|
|
||
| function testAddFundsEnforcesMinimumBalanceForPermanentSubscription() |
There was a problem hiding this comment.
i don't think that this is necessary.
ali-behjati
approved these changes
May 27, 2025
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
Base automatically changed from
devin/1747072255-add-max-deposit-limit-for-permanent-subscriptions
to
main
May 27, 2025 15:42
…evin/1747076033-ensure-minimum-balance-after-adding-funds
tejasbadadare
deleted the
devin/1747076033-ensure-minimum-balance-after-adding-funds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure Subscription Balance > Minimum Balance After Adding Funds
This PR adds a check in the
addFundsfunction to ensure that the subscription balance is greater than the minimum balance after funds are added. This ensures that active subscriptions always maintain the required minimum balance.Changes
Scheduler.solwhere it was checkingstatus.isActiveinstead ofparams.isActiveaddFundsto ensure that active subscriptions maintain minimum balance after funds are addedPulseScheduler.t.solto verify this behavior for both regular and permanent subscriptionsTesting
testAddFundsEnforcesMinimumBalanceto verify minimum balance check for regular subscriptionstestAddFundsEnforcesMinimumBalanceForPermanentSubscriptionto verify minimum balance check for permanent subscriptionsLink to Devin run: https://app.devin.ai/sessions/6a8af4d12771419d86aff4d8c2663944
Requested by: Tejas Badadare (tejas@dourolabs.xyz)