feat(fortuna): Better metrics tracking for alerting #2703
Merged
+167
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
m30m
approved these changes
May 19, 2025
| @@ -228,6 +236,30 @@ impl KeeperMetrics { | |||
| keeper_metrics.block_timestamp_lag.clone(), | |||
| ); | |||
|
|
|||
| writable_registry.register( | |||
| "block_timestamp", | |||
There was a problem hiding this comment.
I would call these latest_block_timestamp and latest_block_number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current metrics system makes it difficult to alert on certain kinds of failure cases. Specifically, chains don't show up in the metrics until they are successfully started, which means that if a chain fails to start, we don't get an alert. I also added a couple of timestamp metrics around the blockchain state logging and event processing. These timestamp metrics will go stale (i.e., out of sync with current time) if they are not updated, which will catch many kinds of failure cases. These case wouldn't be caught with the existing timestamp lag metric, which won't trigger a failure e.g., if the whole block tracking loop crashes.
How has this been tested?