Update eslint and turbo configs for devhub #2738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
cprussin
approved these changes
May 28, 2025
| @@ -13,12 +13,14 @@ | |||
| "fix:lint": { | |||
| "dependsOn": [ | |||
| "//#install:modules", | |||
| "^build", | |||
| "build", | |||
There was a problem hiding this comment.
These two shouldn't actually be needed since this is just a virtual task and has no implementation other than triggering other tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Turbo so that it builds the app before running eslint as the linting requires some generated code. Then update the eslint config to ignore the generated code as it should not be linted.
Rationale
Separating this out from PR #2735 so we can get it merged faster and unblock folks