Skip to content

Conversation

dadepo
Copy link
Contributor

@dadepo dadepo commented Sep 27, 2022

Closes #74

@jayantk
Copy link
Contributor

jayantk commented Sep 27, 2022

thanks! I think the < 1.14.1 constraint can be dropped entirely, but @ali-bahjati will know better than me. I believe the < 1.11 constraint was added because of an issue with the 1.11 solana version that was causing a problem here, but that has been fixed in later versions.

@ali-behjati
Copy link
Collaborator

Hi @dadepo,

Thank you so much for contributing to us! I appreciate if you can address my comments below before merging it.

The reason I set the constraint initially was that the newer version was not compiling properly (#62). I checked and the problem with solana is solved now. However as CI is still failing. To fix the CI you need to update its action config file to use a newer solana version.

Also, please use the latest mainnet version (1.10.40) everywhere instead of the latest crate version as 1) it might have some problems 2) protocols might not be willing to use it 3) without a < constraint protocols using newer versions can still use the newer version of solana package.

@ali-behjati ali-behjati merged commit 6f4a4c0 into pyth-network:main Oct 6, 2022
@ali-behjati
Copy link
Collaborator

Thank you!

@dadepo dadepo deleted the update-solana-deps branch October 6, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version requirement for solana dependencies
3 participants