Update the price schema #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
force-pushed
the
abehjati/fix-price-schema-update
branch
from
489c0dc to
8951952
Compare
tompntn
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is happening because we are not storing a lock file and apparently a newer version of a packaged changes the output of our schema generation code.
The reason for not having lock file in git is that lib crates don't have lock files at all. Not having it in github allows us to catch problems that could happen for downstream consumers. However, this particular one, would not had any impact on downstream consumers.
The schema change itself is very weird and strange, the old one seems to be more accurate semantically.
More context after looking deeper:
It’s using
cosmwasm-schemawhich usesschemarsto generate it. It seems that they have this PR that changed it (as a minor version upgrade) and is the exact root cause of our problem. They have made the change to handle descriptions for each enum field 🤯