Add kms signer #12
Open
Add kms signer #12
+861
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
approved these changes
Jun 30, 2025
ali-behjati
reviewed
Jul 3, 2025
| pub algorithm: ObjectIdentifier, | ||
|
|
||
| /// This field is `OPTIONAL` and contains the ASN.1 `ANY` type, which | ||
| /// in this example allows arbitrary algorithm-defined parameters. |
There was a problem hiding this comment.
seems like a wrong comment.
| } | ||
| } | ||
|
|
||
| /// X.509 `AlgorithmIdentifier` (same as above) |
There was a problem hiding this comment.
can you add a bit of comment what these are, i have no clue.
Comment on lines
+135
to
+139
| pub async fn get_and_cache_public_key(&mut self) -> anyhow::Result<()> { | ||
| let (public_key, pubkey_evm) = self.get_public_key().await?; | ||
| self.public_key = Some((public_key, pubkey_evm)); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
couldn't we just do it in the try_new method above?
| @@ -172,11 +173,14 @@ async fn run_listener(input: RunListenerInput) -> Result<(), PubsubClientError> | |||
| } | |||
|
|
|||
| async fn get_signer(run_options: config::RunOptions) -> anyhow::Result<Arc<dyn Signer>> { | |||
| match run_options.signer_uri.scheme() { | |||
| let scheme = run_options.signer_uri.split("://").next().unwrap_or(""); | |||
| println!("Using signer URI: {}", scheme); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.