Power up pre-commit #237
Merged
Power up pre-commit #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
power-up-pre-commit
branch
2 times, most recently
from
bafb6d7 to
32dbbf7
Compare
basnijholt
force-pushed
the
power-up-pre-commit
branch
4 times, most recently
from
3dab38a to
7c5e689
Compare
jbweston
approved these changes
Dec 11, 2019
A summary of what the hooks do: * `pyupgrade` - A tool (and pre-commit hook) to automatically upgrade syntax for newer versions of the language. * `end-of-file-fixer` - Makes sure files end in a newline and only a newline. * `check-docstring-first` - Checks for a common error of placing code before the docstring. * `check-yaml` - Attempts to load all yaml files to verify syntax. * `debug-statements` - Check for debugger imports and py37+ breakpoint() calls in python source. * `check-ast` - Simply check whether files parse as valid python. * `seed-isort-config` - Statically populate the `known_third_party` `isort` setting because `isort` sucks at figuring out which third party libs are used. (from author of `pre-commit`)
basnijholt
force-pushed
the
power-up-pre-commit
branch
from
7c5e689 to
c60d8ca
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some whitespace checks,
isort,pyupgrade, and some other code checks from thepre-commit-hooksrepo.Note that
pyupgradedoesn't really change much here because I used this already before.A summary of what the hooks do:
pyupgrade- A tool (and pre-commit hook) to automatically upgrade syntax for newer versions of the language.end-of-file-fixer- Makes sure files end in a newline and only a newline.check-docstring-first- Checks for a common error of placing code before the docstring.check-yaml- Attempts to load all yaml files to verify syntax.debug-statements- Check for debugger imports and py37+ breakpoint() calls in python source.check-ast- Simply check whether files parse as valid python.seed-isort-config- Statically populate theknown_third_partyisortsetting becauseisortsucks at figuring out which third party libs are used. (from author ofpre-commit)I have also added this summary to the first commit.