add a Pull Request template #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basnijholt
force-pushed
the
pr-template
branch
from
a64c855 to
090bde7
Compare
Now it should be more clear that one should run `pre-commit`. People probably don't read https://adaptive.readthedocs.io/en/latest/docs.html#development before contributing.
basnijholt
force-pushed
the
pr-template
branch
from
090bde7 to
d3c20ba
Compare
jbweston
approved these changes
Dec 16, 2019
Indeed, they don't 😅 I couldn't find some information about how to contribute in the main README, it would be nice to reference the template there. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it should be more clear that one should run
pre-commit.People probably don't read https://adaptive.readthedocs.io/en/latest/docs.html#development before contributing.
@jbweston and @akhmerov, what do you think?