Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable test of runner using distributed #253

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 18, 2019

Description

It seems to fail a lot on Windows, making the whole pipeline fail.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

It seems to fail a lot on Windows.
@codecov-io
Copy link

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   79.48%   79.48%           
=======================================
  Files          32       32           
  Lines        4402     4402           
  Branches      809      809           
=======================================
  Hits         3499     3499           
  Misses        777      777           
  Partials      126      126
Impacted Files Coverage Δ
adaptive/tests/test_runner.py 94.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0015410...4b16155. Read the comment docs.

@basnijholt basnijholt merged commit 9addcb8 into master Dec 18, 2019
@basnijholt basnijholt mentioned this pull request Jan 16, 2020
@basnijholt basnijholt deleted the disable-distributed-test branch April 18, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants