Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy and pyright tests in CI #1202

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

eltoder
Copy link
Contributor

@eltoder eltoder commented Nov 10, 2023

Summary

Some error messages changed in mypy 1.7.0 and pyright 1.1.335.

Also, test_mypy sometimes fails with xdist (-n auto). A failure I can
reliably reproduce locally is due to changes in type variables numbering.
There may be other issues.

Some error messages changed in mypy 1.7.0 and pyright 1.1.335.

Also, test_mypy sometimes fails with xdist (-n auto). A failure I can
reliably reproduce locally is due to changes in type variables numbering.
There may be other issues.
@eltoder eltoder force-pushed the feature/fix-ci-mypy-pyright branch from 9ce2913 to e3c18ed Compare November 10, 2023 16:15
@hynek hynek requested a review from Tinche November 10, 2023 17:09
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hynek hynek added this pull request to the merge queue Nov 11, 2023
Merged via the queue into python-attrs:main with commit ea1037c Nov 11, 2023
20 checks passed
@eltoder eltoder deleted the feature/fix-ci-mypy-pyright branch November 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants