Fix set_closure_cell on 3.11 #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we'll have to finish this up before 3.11? :-/ |
|
I don't think the other failing tests were related to this, but other 3.11 incompatibilities. Since the beta is out I can revisit this |
vstinner
reviewed
May 25, 2022
| ) | ||
| # And call it to set the cell. | ||
| setter(value) | ||
| if sys.version_info >= (3, 11): |
There was a problem hiding this comment.
In fact, it works since Python 3.8:
There was a problem hiding this comment.
@Tinche: Would you mind to change the version to Python 3.8?
There was a problem hiding this comment.
JFTR Tin is touring Italy right now; I'll pester him once he's back :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for 3.11 compatibility (#907).
Maybe hold off on merging until a discussion on BPO.