Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Unicode license in locale-data and in documentation #1074

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Include Unicode license in locale-data and in documentation #1074

merged 1 commit into from
Apr 22, 2024

Conversation

akx
Copy link
Member

@akx akx commented Apr 19, 2024

Fixes #1072

@akx akx mentioned this pull request Apr 19, 2024
Closed
stefan6419846
stefan6419846 reviewed Apr 19, 2024
View reviewed changes
docs/license.rst Outdated Show resolved Hide resolved
@akx akx force-pushed the unicode-license branch from 87159f1 to 47ca806 Compare April 19, 2024 05:56
@akx akx requested a review from stefan6419846 April 19, 2024 05:56
stefan6419846
stefan6419846 approved these changes Apr 19, 2024
View reviewed changes
Copy link

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One alternative would be to actually use the license file shipped within the actual CLDR archives to always have the latest/correct license file, but the current approach is also fine for me.

@akx akx merged commit 1a03526 into master Apr 22, 2024
21 checks passed
@akx akx deleted the unicode-license branch April 22, 2024 06:54
@akx akx added this to the Babel 2.15 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Babel 2.15
Development

Successfully merging this pull request may close these issues.

Missing license for babel/locale-data
2 participants
@akx @stefan6419846