Reuse InitCatalog's guts in UpdateCatalog #1244
Merged
+48
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
- Coverage 92.07% 92.06% -0.01%
==========================================
Files 27 27
Lines 4692 4688 -4
==========================================
- Hits 4320 4316 -4
Misses 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the catalog initialization logic to fix a bug where pybabel update --init-missing would fail if the target directory didn't exist. The refactoring extracts the catalog initialization code into a shared _init_catalog function that both InitCatalog and UpdateCatalog can use, ensuring consistent behavior including automatic directory creation.
Key changes:
- Introduced a new
_init_cataloghelper function that encapsulates catalog initialization logic and directory creation - Refactored
InitCatalogandUpdateCatalogcommands to use the shared function - Added test coverage for directory creation with
--init-missingflag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| babel/messages/frontend.py | Extracted catalog initialization into _init_catalog function; updated InitCatalog and UpdateCatalog to use shared function with directory creation |
| tests/messages/frontend/test_cli.py | Added test to verify that pybabel update --init-missing creates parent directories when they don't exist |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #1139 (since `_init_catalog` creates directories on the way) Co-authored-by: lando <du33169@qq.com>
akx
force-pushed
the
fix-update-init-missing-redux
branch
from
9826fc5 to
ff8071e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139 (since
_init_catalogcreates directories on the way)Closes #1142 (supersedes it)