Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pytz #231

Closed
tobixen opened this issue Nov 18, 2022 · 1 comment · Fixed by #363
Closed

Remove dependency on pytz #231

tobixen opened this issue Nov 18, 2022 · 1 comment · Fixed by #363

Comments

@tobixen
Copy link
Member

tobixen commented Nov 18, 2022

The pytz and tzlocal libraries are deprecated, in modern python versions timezone handling is included in the embedded libraries - so we should remove all dependencies on pytz. I think I sort of did this already, but then I got into problems. The task is basically to look into the code and search for all instances of pytz and tzlocal and ensure that it's either removed or only used as a fallback should timezones not be available. I vaguely remember that I already did this but had to comment out the work due to problems with the icalendar library.

Problems:

@tobixen tobixen added this to the v.0.12 milestone Nov 18, 2022
sim0nx added a commit to sim0nx/caldav that referenced this issue Dec 19, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2023
…ports.zoneinfo in case of <py3.9 for tests; fixes #231
@tobixen
Copy link
Member Author

tobixen commented Dec 19, 2023

Awesome. Indeed, the icalendar problems have been mended and we've stopped supporting python2, so the shedding of the pytz dependency was overdue. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant