Handle distutils without distutils.msvc9compiler.MSVCCompiler class

[jameshilliard]

Fixes #117.

[jameshilliard]

Think someone could look at this and spin a new release? Without this change cffi is broken on Windows with the latest setuptools release.

[alex]

I think this will solve the issue being experienced. I don't understand what monkey-patching _remove_visual_c_ref was intended to achieve, so I can't quite tell if this is correct.

[arigo]

The patch of _remove_visual_c_ref appears to be for the embedding case. The tests pass here on github but I don't know what version of setuptools that is using. If that's the latest version, then apparently the patch is not needed any more with that version.

[nitzmahone]

Our guess is that it's related to long-dead versions of the Microsoft toolchain that we have no ability to install/test- we didn't try to evaluate if it was actually useful when we shimmed distutils.

The PR looks good to me to get things working again (and this issue is also an excellent illustration of why we should be pinning setuptools upper bounds in our releases- it wouldn't have been possible to break this way).

We'll get that merged and kick off a release this week- thanks!

[MarkCallow]

I see release 1.17.1 has been made that includes this fix. The Releases section only shows the source code. Has the release been uploaded to pypl.org for pip to find?

[nitzmahone]

Yep, immediately after the release was tagged: https://pypi.org/project/cffi/1.17.1/#files

[viblo]

Not sure if its more fitting to ask in the Pypy tracker, but could you also update the version used by Pypy to use the updated cffi?

[saschanaz]

That seems pypy/pypy#5027 and is already done by pypy/pypy@87024e9

(And yes it should be asked in the pypy tracker)

[viblo]

Ah of course. Great, thanks!

[larsoner]

Seems like we're getting a new failure in python-rtmixer:

spatialaudio/python-rtmixer#60
https://github.com/spatialaudio/python-rtmixer/actions/runs/10882693787/job/30194263112?pr=60#step:4:14395

I haven't investigated why, but at least the same build last month worked, and we didn't change any code (though it's always possible the windows-latest image updated or something):

https://github.com/spatialaudio/python-rtmixer/actions/runs/10249497029/job/28353006823

[alex]

This is because PyPy includes its own copy of cffi, this won't be resolved until there's a new PyPy release.

…

On Mon, Sep 16, 2024 at 11:36 AM Eric Larson ***@***.***> wrote: Seems like we're getting a new failure in python-rtmixer: spatialaudio/python-rtmixer#60 <spatialaudio/python-rtmixer#60> I haven't investigated why, but at least the same build last month worked, and we didn't change any code (though it's always possible the windows-latest image updated or something): https://github.com/spatialaudio/python-rtmixer/actions/runs/10249497029/job/28353006823 — Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBEFCRDLBL5XDJWBTPLZW33H3AVCNFSM6AAAAABNJ2VVXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGI3DCMRRGQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.

[arigo]

If this runs with a newer version of PyPy than the previous run, then you might need to report that as an issue on the PyPy issue tracker to make sure they are aware that something broke.

[alex]

pypy/pypy@87024e9 is the fix for pypy, it's just not in a release

…

On Mon, Sep 16, 2024 at 2:18 PM Armin Rigo ***@***.***> wrote: If this runs with a newer version of PyPy than the previous run, then you might need to report that as an issue on the PyPy issue tracker to make sure they are aware that something broke. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.