add website, github, and location info to User Model #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
可以补上前端对应的设置页面提在一个pr里 |
Contributor
Author
|
好的 |
killpanda
changed the title
killpanda
changed the title
killpanda
referenced
this pull request
in killpanda/firefly
Sep 9, 2015
killpanda
force-pushed
the
add-fields
branch
from
8b43753 to
41acf40
Compare
killpanda
changed the title
Contributor
Author
|
@halfcrazy 这个 PR 已经完成 |
Member
|
@killpanda 咦，为什么在我这里看CI挂了。 |
Contributor
Author
|
@halfcrazy 是呀，不过看着报错信息还挺奇怪的。比方说 assert current_user.is_authenticated()
TypeError: 'bool' object is not callable |
Member
|
@killpanda 这个的意思是 |
Contributor
Author
|
@halfcrazy 这个地方我没有动过，并且在尝试 很好奇之前 CI 也是通过的吗？ |
Member
|
@killpanda 之前肯定是通的啦。你可以看一下最近合并的那次pr，后面是绿色的箭头。我看了一下你提交的代码，会不会跟你第二个commit里面 |
killpanda
force-pushed
the
add-fields
branch
from
bd837f6 to
41acf40
Compare
Contributor
Author
|
所以这个 PR 是不是需要等 #114 合并之后再合？ |
killpanda
force-pushed
the
add-fields
branch
from
e6d452a to
4312d38
Compare
Contributor
Author
|
CI 过了... @halfcrazy |
Member
1 similar comment
Member
halfcrazy
added a commit
that referenced
this pull request
Sep 13, 2015
add website, github, and location info to User Model
Contributor
Author
|
thx @halfcrazy @mozillazg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
对应的 Trello 链接 https://trello.com/c/AEVdVhFX
添加了一个非常临时的
template主要是用于测试