Work around numpy/numpy#21889 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a nice workaround for now, until numpy is fixed! I think you should tag & publish it on pip to have it working again. As is, I tried the install on ubuntu and fedora, and tried installing older versions of slycot - but obviously nothing worked since the issue was with numpy all along :) |
|
Thanks @matthieuvigne Yes, we need a new release. It's been over two years since 0.4.0 already and we made quite some fixes and enhancements. I don't have access to the pypi credentials, though. Any thoughts @roryyorke? |
|
No objections from me. I'll have some time Sunday or next weekend.
…On Thu, 30 Jun 2022, 16:46 Ben Greiner, ***@***.***> wrote:
Thanks @matthieuvigne <https://github.com/matthieuvigne>
Yes, we need a new release. It's been over two years since 4.0.0 already
and we made quite some fixes and enhancements.
I don't have access to the pypi credentials thoug. Any thoughts @roryyorke
<https://github.com/roryyorke>?
—
Reply to this email directly, view it on GitHub
<#178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3C7SI6OENU27JJ4L527LVRWXNVANCNFSM52I4U4PA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ran out of time today, sorry. Should have some time next weekend.
…On Fri, 01 Jul 2022, 14:31 Rory Yorke, ***@***.***> wrote:
No objections from me. I'll have some time Sunday or next weekend.
On Thu, 30 Jun 2022, 16:46 Ben Greiner, ***@***.***> wrote:
> Thanks @matthieuvigne <https://github.com/matthieuvigne>
>
> Yes, we need a new release. It's been over two years since 4.0.0 already
> and we made quite some fixes and enhancements.
>
> I don't have access to the pypi credentials thoug. Any thoughts
> @roryyorke <https://github.com/roryyorke>?
>
> —
> Reply to this email directly, view it on GitHub
> <#178 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAA3C7SI6OENU27JJ4L527LVRWXNVANCNFSM52I4U4PA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around numpy/numpy#21889 as reported in #177