#219 - changing snmp base collector to actually implement collect #310
Conversation
…nt the collect method
|
Tests are failing due to lack of pysnmp... Will investigate later how other collectors are solving this problem with external dependencies. |
|
So we applied your fix and got the SNMPInterfaceCollector/SNMPRawCollector working but we have run into this issue. Any thoughts ? |
|
@jrpaz reading through that issue it seems like it was never fixed (just acknowledged that it was a problem) so it doesn't surprise me that's still the case... |
|
I'm actually witnessing the same issue, it would be rather nice to have this fix merged in! |
|
Seems like this might be a dup of PR #63, though that PR reaches further out |
|
@jaingaurav I agree... I didn't notice that PR existed before I made this one... Feel free to close this one whenever you want assuming the other PR works (and eventually gets merged) |
|
Hello, @jaingaurav Any updates on this issue ? snmpcollector aren't working for a while :( |
|
why doesn‘t merge this request? |
|
Merged, thanks for the pull request (and sorry for the wait). |
Unless I missed something terribly obvious the SNMP base collector (used by all the other SNMP collectors like SNMPRawCollector, SNMPInterfaceCollector, etc) never implemented the collect() method, resulting in a NotImplementedException every time you tried to use one of these.
It's not really obvious to me how this was ever working or how it got to this state... Perhaps there was an API change at some point in the past or something.
Nevertheless, I've quickly hacked a change that makes it work (though I haven't really tested it with all the SNMP collectors, nor have I written any tests for this) and I'd like to get some feedback :)