Port all common checks to pydis_core.utils.checks #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shtlrs
changed the title
shtlrs
force-pushed
the
migrate-common-checks
branch
from
f317c2b
to
9400fc2
Compare
|
Could you update the docstrings so that the auto-docs format correctly? https://github.com/python-discord/bot-core/blob/main/docs/README.md#docstrings for the docs, you can reference another class for examples |
shtlrs
force-pushed
the
migrate-common-checks
branch
4 times, most recently
from
5683e96
to
3d06ece
Compare
shtlrs
force-pushed
the
migrate-common-checks
branch
from
3d06ece
to
b869662
Compare
|
Merged and released in 10.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks module in both
botandsir-lancebotandsir-robinare almost the exact same (sir robin has one related to aoc) but are replicated in 3 places.The checks' purposes are also generic, and are not context specific, so it's better to place them here.
This pull request is part of #85 where we port common code in all of our bots.