Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static content site commands to tags #1473

Closed
Numerlor opened this issue Mar 18, 2021 · 5 comments · Fixed by #1539
Closed

Move static content site commands to tags #1473

Numerlor opened this issue Mar 18, 2021 · 5 comments · Fixed by #1539
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features

Comments

@Numerlor
Copy link
Contributor

The site commands tools, resources, help and home construct embeds from mostly static strings, with only the site url being variable. The url is already referenced in other tags so this won't bring any additional maintenance in the case it does change for some reason.
Moving them to tags will also allow the more direct fuzzy matching and per channel cooldowns to take effect.
With the other commands removed the only left will be the rules command; I think we should move it to the Information or Utils cog and get rid of the Site cog

@MarkKoz MarkKoz added a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features labels Apr 7, 2021
@MarkKoz
Copy link
Member

MarkKoz commented Apr 7, 2021

I agree. That would be a good refactor.

@Numerlor
Copy link
Contributor Author

Numerlor commented Apr 8, 2021

Which commands do we want moved?
Looking at it there's the site home/about and site help commands, which don't looks like they'd fit a tag, at least if the current names are kept. But I don't think they get much use, what do the usage stats look like for them?

@MarkKoz
Copy link
Member

MarkKoz commented Apr 8, 2021

Last 6 months:

site_resources  4 K
site_rules  4 K
site_tools  84
site_home   72
site_faq    43
site_help   10

I don't see why they all can't be tags (except rules). I guess the names should be like sitefaq, sitehome, etc.

@Numerlor
Copy link
Contributor Author

Numerlor commented Apr 8, 2021

My main concern here is site-help, as a tag I don't think the name really fits it and it may be used in a fashion similar to how the ask tag was used.

@ChrisLovering
Copy link
Member

I think each of them could be ported across to tags, using their root aliases. I rarely ever see people doing !site resources, instead they opt for !resources, similar story for the others.

As for the site-help tag specifically, I brought it up with other core devs, and we agreed that it should be dropped entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants