-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move static content site commands to tags #1539
Conversation
How would this work? Currently we don't have embed titles for tags, unless you mean we should make the start of the files |
We could use a similar approach to the branding repo and put the tag metadata in the YAML frontmatter of the markdown documents. For example: ---
title: How to get rich, fast.
---
1. Buy stonks
2. Watch stonks
3. ????
4. Profit |
I was only planning to do it with a bold text at the start like in ToxicKidz' comment, but implementing this shouldn't be too hard and will give more flexibility around tags in general so I'll do that. |
Thinking about it, that is likely out of scope for this specific PR. Maybe we group that in with #1545 so we can have richer tag data.
Up to you, I know that the URL embeds don't look too great, and I think that the inline hyperlinks looks fine. |
I'll wait for the feature to go through then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't think we should wait for tag grouping before moving along with this. It wouldn't change anything about the current functionality, we can group them later on when we merge the other PR. |
The PR is stalled because the group PR should also introduce the ability to pass in embed arguments through the tag file to be used as titles, after the issue is approved. I suppose it could also be done in a PR separate from the grouping functionality but I don't think it'd be worth complicating it just to merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Numerlor since the tags PR is merged I removed the stalled label. |
should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and all works good, bar my one comment.
Discord does validation on the embed url which may fail for valid local urls
Creates the
resources
,faq
andtools
tags from the corresponding site commands and thesite
tag from thehome
/about
command. Therules
command was moved to theInformation
cog, andsite help
was removed along with the cog.closes: #1473