Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps Pip Licences #1902

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Bumps Pip Licences #1902

merged 1 commit into from
Oct 21, 2021

Conversation

HassanAbouelela
Copy link
Member

Updates the pip-licences version to fix a breaking bug in the currently pinned version.

Example of breakage: workflow run

Relevant bug report: raimon49/pip-licenses/issues/113

@HassanAbouelela
Bumps Pip Licences
fc47cf4 
Updates the pip-licences version to fix a breaking bug in the currently
pinned version.

Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
@HassanAbouelela HassanAbouelela added a: dependencies Related to package dependencies and management p: 0 - critical Needs to be addressed ASAP labels Oct 21, 2021
Akarys42
Akarys42 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly the quality I am expecting from an engineering student, excellent

@Akarys42 Akarys42 enabled auto-merge October 21, 2021 20:16
ChrisLovering
ChrisLovering approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely incredible. Nothing short of a miracle how you increased the number like that, very good job!

@Akarys42 Akarys42 merged commit 816f73f into main Oct 21, 2021
@Akarys42 Akarys42 deleted the bump-licenses branch October 21, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akarys42 Akarys42 Akarys42 approved these changes

@ChrisLovering ChrisLovering ChrisLovering approved these changes

Assignees
No one assigned
Labels
a: dependencies Related to package dependencies and management p: 0 - critical Needs to be addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HassanAbouelela @ChrisLovering @Akarys42