Ask for confirmation when banning members with elevated roles

bot/exts/moderation/infraction/_utils.py

@@ -3,7 +3,10 @@
 import arrow
 import discord
 from botcore.site_api import ResponseCodeError
+from botcore.utils import interactions
+from discord import ButtonStyle, Interaction, Message, TextChannel
 from discord.ext.commands import Context
+from discord.ui import Button
 
 import bot
 from bot.constants import Colours, Icons
@@ -269,3 +272,43 @@ async def send_private_embed(user: MemberOrUser, embed: discord.Embed) -> bool:
             "The user either could not be retrieved or probably disabled their DMs."
         )
         return False
+
+
+class StaffBanConfirmationView(interactions.ViewWithUserAndRoleCheck):
+    """The confirmation view that is sent when a moderator attempts to ban a staff member."""
+
+    def __init__(
+        self,
+        *,
+        allowed_users: t.Sequence[int],
+        allowed_roles: t.Sequence[int],
+        timeout: t.Optional[float] = 180,
+        message: t.Optional[Message] = None
+    ) -> None:
+        super().__init__(
+            allowed_users=allowed_users,
+            allowed_roles=allowed_roles,
+            timeout=timeout,
+            message=message
+        )
+
+        self.value: t.Optional[bool] = None
+
+    async def send(self, channel: TextChannel, *, message_content: str) -> None:
+        """Send this view to the given channel with the given message content."""
+        self.message = await channel.send(message_content, view=self)
+
+    @discord.ui.button(label="Confirm", style=ButtonStyle.green)
+    async def confirm(self, interaction: Interaction, button: Button) -> None:
+        """Callback coroutine that is called when the "confirm" button is pressed."""
+        await interaction.response.defer()
+        self.value = True
+        self.stop()
+
+    @discord.ui.button(label="Cancel", style=ButtonStyle.red)
+    async def cancel(self, interaction: Interaction, button: Button) -> None:
+        """Callback coroutine that is called when the "cancel" button is pressed."""
+        await interaction.response.defer()
+        self.value = False
+        await super().on_timeout()
+        self.stop()

bot/exts/moderation/infraction/infractions.py

@@ -466,12 +466,6 @@ async def apply_ban(
             log.trace("Old tempban is being replaced by new permaban.")
             await self.pardon_infraction(ctx, "ban", user, send_msg=is_temporary)
 
-        infraction = await _utils.post_infraction(ctx, user, "ban", reason, active=True, **kwargs)
-        if infraction is None:
-            return None
-
-        infraction["purge"] = "purge " if purge_days else ""
-
         self.mod_log.ignore(Event.member_remove, user.id)
 
         if reason:
@@ -480,6 +474,47 @@ async def apply_ban(
         async def action() -> None:
             await ctx.guild.ban(user, reason=reason, delete_message_days=purge_days)
 
+        if isinstance(user, Member) and any(role.id in constants.STAFF_PARTNERS_COMMUNITY_ROLES for role in user.roles):
+            confirmation_view = _utils.StaffBanConfirmationView(
+                allowed_users=(ctx.author.id,),
+                allowed_roles=constants.MODERATION_ROLES,
+                timeout=10,
+            )
+
+            await confirmation_view.send(
+                ctx.channel,
+                message_content="That user is a Helper. Are you sure you want to ban them?",
+            )
+
+            await confirmation_view.wait()
+            if confirmation_view.value is None:
+                log.trace(
+                    "Attempted ban of user %s by moderator %s cancelled due to timeout.",
+                    str(user),
+                    str(ctx.author),
+                )
+
+                return None
+
+            elif confirmation_view.value is False:
+                log.trace(
+                    "Attempted ban of user %s by moderator %s cancelled due to manual cancel.",
+                    str(user),
+                    str(ctx.author),
+                )
+
+                return None
+
+        # There are a few ways we could get here:
+        # The user was not a member, which means they can't be staff
+        # The user was a member and not staff, so just ban them
+        # The user was a staff and the ban was confirmed
+        infraction = await _utils.post_infraction(ctx, user, "ban", reason, active=True, **kwargs)
+        if infraction is None:
+            return None
+
+        infraction["purge"] = "purge " if purge_days else ""
+
         await self.apply_infraction(ctx, infraction, user, action)
 
         bb_cog: t.Optional[BigBrother] = self.bot.get_cog("Big Brother")