Do not account for jump urls for voice channels #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtlrs
commented
Apr 22, 2023
bot/utils/channel.py
Outdated
| channel: discord.TextChannel | discord.DMChannel | discord.Thread | discord.StageChannel | ||
| ) -> bool: | ||
| """Return True if `channel` is a voice one.""" | ||
| return channel.type in [discord.ChannelType.voice, discord.ChannelType.stage_voice] |
There was a problem hiding this comment.
We might want to account for null channels that we ignore here.
In that case, I'm not sure what value to return 🤔
There was a problem hiding this comment.
I guess we can just let it throw, and handle those case by case if they will ever occur instead of possibly inferring the wrong type.
mbaruh
reviewed
Apr 23, 2023
shtlrs
force-pushed
the
2555-empty-message-upon-superstarify
branch
from
10cde5d
to
c0773f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2555
on_voice_state_updateevents do not havemessageattributes in their context.Which is why we'll ignore setting the
jump_urlfor infractions triggered by these events.