Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference the /tag slash-command instead of the old !tags in the footer of tags listings #2987

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Reference the /tag slash-command instead of the old !tags in the footer of tags listings #2987

merged 2 commits into from
Apr 6, 2024

Conversation

hedyhli
Copy link
Member

@hedyhli hedyhli commented Mar 29, 2024 •
edited
Loading

I have written a way too long PR title but I think that'll explain it 😄

image image

We don't have a !tags anymore. It should reference /tag instead.

@hedyhli hedyhli added a: frontend Related to output and formatting p: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve labels Mar 29, 2024
wookie184
wookie184 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hedyhli hedyhli enabled auto-merge April 2, 2024 04:53
jchristgit
jchristgit approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jchristgit jchristgit disabled auto-merge April 6, 2024 14:45
@jchristgit jchristgit merged commit f686da5 into main Apr 6, 2024
5 checks passed
@jchristgit jchristgit deleted the fix/tags-list-footer branch April 6, 2024 14:45
@hedyhli hedyhli mentioned this pull request Apr 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit approved these changes

@wookie184 wookie184 wookie184 approved these changes

Assignees
No one assigned
Labels
a: frontend Related to output and formatting p: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hedyhli @wookie184 @jchristgit