Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push raw to pastebin if too long for Discord #3038

Merged
merged 2 commits into from
May 17, 2024
Merged

Push raw to pastebin if too long for Discord #3038

merged 2 commits into from
May 17, 2024

Conversation

ChrisLovering
Copy link
Member

This also removes the use of a paginator entirely.

Closes #1037

Examples

Short messages

Before:
image
After:
image

Long messages

Before:
Error, see sentry issue linked above
After:
image
Which links to https://paste.pythondiscord.com/XK7WHB7I4I4HDAF36XMY5ZSNEY

@ChrisLovering ChrisLovering force-pushed the feat/1037/push-raw-to-pastebin-if-too-long branch 3 times, most recently from 3f2eb47 to 10032e6 Compare April 30, 2024 08:25
@vivekashok1221 vivekashok1221 self-requested a review May 3, 2024 19:08
@Xithrius Xithrius added a: frontend Related to output and formatting a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels May 13, 2024
wookie184
wookie184 requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, minor comments.

bot/exts/info/information.py Outdated Show resolved Hide resolved
bot/exts/info/information.py Outdated Show resolved Hide resolved
@ChrisLovering ChrisLovering force-pushed the feat/1037/push-raw-to-pastebin-if-too-long branch from 10032e6 to 56ecf7d Compare May 13, 2024 18:14
@ChrisLovering
Push raw to pastebin if too long for Discord
e383e22 
This also removes the use of a paginator entirely
@ChrisLovering ChrisLovering force-pushed the feat/1037/push-raw-to-pastebin-if-too-long branch from 56ecf7d to e383e22 Compare May 13, 2024 18:15
wookie184
wookie184 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thanks!

Xithrius
Xithrius approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long

@Xithrius Xithrius enabled auto-merge (squash) May 17, 2024 18:30
@Xithrius Xithrius merged commit 1e73aa4 into main May 17, 2024
5 checks passed
@Xithrius Xithrius deleted the feat/1037/push-raw-to-pastebin-if-too-long branch May 17, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xithrius Xithrius Xithrius approved these changes

@wookie184 wookie184 wookie184 approved these changes

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

@vivekashok1221 vivekashok1221 Awaiting requested review from vivekashok1221

Assignees
No one assigned
Labels
a: frontend Related to output and formatting a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) s: needs review Author is waiting for someone to review and approve t: enhancement Changes or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raw command doesn't trim lines that are too long for the paginator
3 participants
@ChrisLovering @Xithrius @wookie184