Prometheus configuration auto-reloading #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jb3
added
component: networking
jchristgit
reviewed
Jun 10, 2024
kubernetes/namespaces/monitoring/alerts/alerts.d/prometheus.yaml
Outdated
Show resolved
Hide resolved
kubernetes/namespaces/monitoring/alerts/alerts.d/prometheus.yaml
Outdated
Show resolved
Hide resolved
kubernetes/namespaces/monitoring/prometheus/reloader-script.yaml
Outdated
Show resolved
Hide resolved
kubernetes/namespaces/monitoring/prometheus/reloader-script.yaml
Outdated
Show resolved
Hide resolved
kubernetes/namespaces/monitoring/prometheus/reloader-script.yaml
Outdated
Show resolved
Hide resolved
kubernetes/namespaces/monitoring/prometheus/reloader-script.yaml
Outdated
Show resolved
Hide resolved
|
Looks good.
I pushed a PR to inotify-base to slim it down. We may need to adjust the
notify script here to use `/bin/sh` instead of `/bin/bash` for
wider compatibility. As far as I can see it uses no bashisms.
|
jb3
force-pushed
the
jb3/kubernetes/266-prometheus-config-reload
branch
from
3f2e65d
to
990cefd
Compare
|
All review comments have been addressed in the force push. |
jb3
force-pushed
the
jb3/kubernetes/266-prometheus-config-reload
branch
from
990cefd
to
499bb71
Compare
jb3
force-pushed
the
jb3/kubernetes/266-prometheus-config-reload
branch
from
499bb71
to
7e76e2a
Compare
jchristgit
approved these changes
Jun 10, 2024
|
Thanks! |
1 similar comment
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a repository, owl-corp/inotify-base, which is a
Debian slim image with some added niceities to trigger a script run on changes
to a given path.
We then have a script in this repository to reload Prometheus using the
management API and notify in the Discord channel if this has succeeded or not.
I have also enabled scraping of the Prometheus server and also added an alert
for failed config reloads to integrate it into our existing alerting pipeline.
Makes progress on #266, there is still no auto-deployment of content from this repository.