Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat NGINX responses as UTF-8 #530

Closed
wants to merge 1 commit into from
Closed

Treat NGINX responses as UTF-8 #530

wants to merge 1 commit into from

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Sep 2, 2024

Some sites that had non-ASCII characters rendered weirdly because our
NGINX configuration was not returning a default charset and so rendering
was being left up to browser/standards defaults.

This change adds a new config file to /etc/nginx/conf.d/ which forces
responses to be interpreted as/transformed to UTF-8.

Some sites that had non-ASCII characters rendered weirdly because our
NGINX configuration was not returning a default charset and so rendering
was being left up to browser/standards defaults.

This change adds a new config file to /etc/nginx/conf.d/ which forces
responses to be interpreted as/transformed to UTF-8.
@github-actions github-actions bot added the group: ansible Issues and pull requests related to the Ansible setup label Sep 2, 2024
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

To be honest, our nginx configurations should IMO all live in conf.d. It
doesn't really make sense to mess around with sites-available and
sites-enabled given we already have a configuration management here. But
maybe a topci for another day.

@jchristgit
Copy link
Member

Ap
pliied in main. Thanks!

@jchristgit jchristgit closed this Sep 2, 2024
@jb3 jb3 deleted the jb3/fixes/nginx-utf8 branch September 3, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group: ansible Issues and pull requests related to the Ansible setup
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants